[Linux-kernel-mentees] [PATCH v5 1/5] Documentation: RCU: Convert RCU basic concepts to reST

Steven Rostedt rostedt at goodmis.org
Thu Jun 27 15:13:24 UTC 2019

On Thu, 27 Jun 2019 08:34:43 -0600
Jonathan Corbet <corbet at lwn.net> wrote:

> On Wed, 26 Jun 2019 15:07:01 -0500
> Jiunn Chang <c0d1n61at3 at gmail.com> wrote:
> > RCU basic concepts reST markup.
> > 
> > Signed-off-by: Jiunn Chang <c0d1n61at3 at gmail.com>
> > Reviewed-by: Joel Fernandes (Google) <joel at joelfernandes.org>  
> So this is a little detail but ... your signoff should be the last thing
> in the set of tags on the patch.

Note, I've been seeing this a lot lately, and then noticed, that when I
downloaded a patch directly from patchwork, it placed all the
Reviewed-by and Acked-by tags after the original Signed-off-by. I
checked the original patch on the mailing list, and it had no other
tags but the Signed-off-by. I then pulled one of my own patches, and it
did it to that patch as well.

I too prefer the Signed-off-by be last, but our tooling needs to do
this as well, otherwise it's a failure in our procedures.

-- Steve

More information about the Linux-kernel-mentees mailing list