[Linux-kernel-mentees] [PATCH v2] packet: Fix undefined behavior in bit shift

Shuah Khan skhan at linuxfoundation.org
Thu Jun 27 16:52:10 UTC 2019

On 6/27/19 10:22 AM, David Miller wrote:
> From: Shuah Khan <skhan at linuxfoundation.org>
> Date: Wed, 26 Jun 2019 21:32:52 -0600
>> On 6/26/19 9:25 PM, Jiunn Chang wrote:
>>> Shifting signed 32-bit value by 31 bits is undefined.  Changing most
>>> significant bit to unsigned.
>>> Changes included in v2:
>>>     - use subsystem specific subject lines
>>>     - CC required mailing lists
>> These version change lines don't belong in the change log.
> For networking changes I actually like the change lines to be in the
> commit log.  So please don't stray people this way, thanks.

As a general rule, please don't include change lines in the commit log.
For networking changes that get sent to David and netdev, as David
points out here, he likes them in the commit log, please include them
in the commit log.

I am working on FAQ (Frequently Answered Questions) section for mentees.
I will add this to it.

-- Shuah

More information about the Linux-kernel-mentees mailing list