[Linux-kernel-mentees] [PATCH v2 1/3] lspci: Include -vvv option in help

Bjorn Helgaas bjorn.helgaas at gmail.com
Thu May 16 12:51:55 UTC 2019


On Sat, May 11, 2019 at 6:05 PM Kelsey Skunberg
<skunberg.kelsey at gmail.com> wrote:
>
> Listed -vvv within the help page so highest used level of verbose
> in lspci is known

This tells what *you* did; using the imperative mood would put the
focus on what the *patch* does.  Also missing the period.  Maybe:

  Include "-vvv" in help message.

> Signed-off-by: Kelsey Skunberg <skunberg.kelsey at gmail.com>
> ---
>  lspci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lspci.c b/lspci.c
> index d63b6d0..937c6e4 100644
> --- a/lspci.c
> +++ b/lspci.c
> @@ -41,7 +41,7 @@ static char help_msg[] =
>  "-t\t\tShow bus tree\n"
>  "\n"
>  "Display options:\n"
> -"-v\t\tBe verbose (-vv for very verbose)\n"
> +"-v\t\tBe verbose (-vv or -vvv for higher verbosity)\n"
>  #ifdef PCI_OS_LINUX
>  "-k\t\tShow kernel drivers handling each device\n"
>  #endif
> --
> 2.20.1
>


More information about the Linux-kernel-mentees mailing list