[Linux-kernel-mentees] [PATCH 4/4] net: mac80211: mlme.c: Add lockdep condition for RCU list usage

Johannes Berg johannes at sipsolutions.net
Fri Apr 24 09:24:40 UTC 2020


On Thu, 2020-04-09 at 13:59 +0530, madhuparnabhowmik10 at gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik10 at gmail.com>
> 
> ieee80211_add_vht_ie() is called with sdata->wdev.mtx held from
> ieee80211_send_assoc(). Add lockdep condition to avoid false positive
> warnings.

Again, wrong lock!

Over the course of the three patches, you've now claimed that any one of

 * RTNL,
 * local->iflist_mtx,
 * local->mtx, and
 * sdata->wdev.mtx

are sufficient to iterate the interface list, but only the first two are
really true.

johannes



More information about the Linux-kernel-mentees mailing list