[Linux-kernel-mentees] [PATCH v2 0/2] realtek ethernet : remove legacy power management callbacks.

Vaibhav Gupta vaibhav.varodek at gmail.com
Wed Apr 29 14:23:36 UTC 2020


On Tue, 28 Apr 2020 at 23:24, Heiner Kallweit <hkallweit1 at gmail.com> wrote:
>
> On 28.04.2020 16:43, Vaibhav Gupta wrote:
> > The purpose of this patch series is to remove legacy power management callbacks
> > from realtek ethernet drivers.
> >
> > The callbacks performing suspend() and resume() operations are still calling
> > pci_save_state(), pci_set_power_state(), etc. and handling the powermanagement
> > themselves, which is not recommended.
> >
> Did you test any of the changes? If not, then mention this at least.
> A typical comment in the commit message would be "compile-tested only".
Yeah its compile-tested only. I should have mention that. Thanks for
pointing it out.
>
> In addition the following should be changed.
> [Linux-kernel-mentees] [PATCH v2 0/2]
> Use
> [PATCH net-next v2 0/2]
> instead.
Sure!

--Vaibhav Gupta
>
> > The conversion requires the removal of the those function calls and change the
> > callback definition accordingly.
> >
> > Vaibhav Gupta (2):
> >   realtek/8139too: Remove Legacy Power Management
> >   realtek/8139cp: Remove Legacy Power Management
> >
> >  drivers/net/ethernet/realtek/8139cp.c  | 25 +++++++------------------
> >  drivers/net/ethernet/realtek/8139too.c | 26 +++++++-------------------
> >  2 files changed, 14 insertions(+), 37 deletions(-)
> >
>


More information about the Linux-kernel-mentees mailing list