[Linux-kernel-mentees] [PATCH v1] PCI: Add support for LTR
kernel test robot
lkp at intel.com
Tue Aug 25 15:29:05 UTC 2020
Hi Puranjay,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on pci/next]
[also build test ERROR on pm/linux-next v5.9-rc2 next-20200825]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Puranjay-Mohan/PCI-Add-support-for-LTR/20200825-014435
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: x86_64-randconfig-r022-20200825 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 77e5a195f818b9ace91f7b12ab948b21d7918238)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>
All errors (new ones prefixed by >>):
>> drivers/pci/pci-acpi.c:1236:8: error: no member named 'max_snoop_latency' in 'struct pci_dev'
dev->max_snoop_latency = (u16)elements[1].integer.value |
~~~ ^
>> drivers/pci/pci-acpi.c:1238:8: error: no member named 'max_nosnoop_latency' in 'struct pci_dev'
dev->max_nosnoop_latency = (u16)elements[3].integer.value |
~~~ ^
2 errors generated.
# https://github.com/0day-ci/linux/commit/fa2179400e50db2342c6d6445c8805a773ec9dc9
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Puranjay-Mohan/PCI-Add-support-for-LTR/20200825-014435
git checkout fa2179400e50db2342c6d6445c8805a773ec9dc9
vim +1236 drivers/pci/pci-acpi.c
1215
1216 /* pci_acpi_evaluate_ltr_latency
1217 *
1218 * @dev - the pci_dev to evaluate and save latencies
1219 */
1220 void pci_acpi_evaluate_ltr_latency(struct pci_dev *dev)
1221 {
1222 union acpi_object *obj, *elements;
1223 struct acpi_device *handle;
1224
1225 handle = ACPI_HANDLE(&dev->dev);
1226 if (!handle)
1227 return;
1228
1229 obj = acpi_evaluate_dsm(handle, &pci_acpi_dsm_guid, 0x2,
1230 DSM_PCI_LTR_MAX_LATENCY, NULL);
1231 if (!obj)
1232 return;
1233
1234 if (obj->type == ACPI_TYPE_PACKAGE && obj->package.count == 4) {
1235 elements = obj->package.elements;
> 1236 dev->max_snoop_latency = (u16)elements[1].integer.value |
1237 ((u16)elements[0].integer.value << PCI_LTR_SCALE_SHIFT);
> 1238 dev->max_nosnoop_latency = (u16)elements[3].integer.value |
1239 ((u16)elements[2].integer.value << PCI_LTR_SCALE_SHIFT);
1240 }
1241 ACPI_FREE(obj);
1242 }
1243
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 29189 bytes
Desc: not available
URL: <http://lists.linuxfoundation.org/pipermail/linux-kernel-mentees/attachments/20200825/56ecaa24/attachment-0001.gz>
More information about the Linux-kernel-mentees
mailing list