[Linux-kernel-mentees] [PATCH] scripts: Add intended executable mode and SPDX license

Lukas Bulwahn lukas.bulwahn at gmail.com
Thu Aug 27 06:16:33 UTC 2020


On Thu, Aug 27, 2020 at 8:13 AM Mrinal Pandey <mrinalmni at gmail.com> wrote:
>
> On 20/08/27 11:35AM, Mrinal Pandey wrote:
> > commit b72231eb7084 ("scripts: add spdxcheck.py self test") added the file
> > spdxcheck-test.sh to repository without the executable flag and license

s/to/to the/

> > information.
> >
> > commit eb8305aecb95 ("scripts: Coccinelle script for namespace
> > dependencies.") added the file nsdeps, commit 313dd1b62921 ("gcc-plugins:
> > Add the randstruct plugin") added the file gcc-plugins/gen-random-seed.sh
> > and commit 9b4ade226f74 ("xen: build infrastructure for generating
> > hypercall depending symbols") added the file xen-hypercalls.sh without the
> > executable bit.
> >
> > Set to usual modes for these files and provide the SPDX license for
> > spdxcheck-test.sh. No functional changes.
> >
> > Signed-off-by: Mrinal Pandey <mrinalmni at gmail.com>
> > ---
> >  scripts/gcc-plugins/gen-random-seed.sh | 0
> >  scripts/nsdeps                         | 0
> >  scripts/spdxcheck-test.sh              | 2 +-
> >  scripts/xen-hypercalls.sh              | 0
> >  4 files changed, 1 insertion(+), 1 deletion(-)
> >  mode change 100644 => 100755 scripts/gcc-plugins/gen-random-seed.sh
> >  mode change 100644 => 100755 scripts/nsdeps
> >  mode change 100644 => 100755 scripts/spdxcheck-test.sh
> >  mode change 100644 => 100755 scripts/xen-hypercalls.sh
> >
> > diff --git a/scripts/gcc-plugins/gen-random-seed.sh b/scripts/gcc-plugins/gen-random-seed.sh
> > old mode 100644
> > new mode 100755
> > diff --git a/scripts/nsdeps b/scripts/nsdeps
> > old mode 100644
> > new mode 100755
> > diff --git a/scripts/spdxcheck-test.sh b/scripts/spdxcheck-test.sh
> > old mode 100644
> > new mode 100755
> > index cfea6a0d1cc0..758fa645ed99
> > --- a/scripts/spdxcheck-test.sh
> > +++ b/scripts/spdxcheck-test.sh
> > @@ -1,5 +1,5 @@
> >  #!/bin/sh
> > -

Why do you delete the newline?

> > +# SPDX-License-Identifier: GPL-2.0
> >  for PYTHON in python2 python3; do
> >       # run check on a text and a binary file
> >       for FILE in Makefile Documentation/logo.gif; do
> > diff --git a/scripts/xen-hypercalls.sh b/scripts/xen-hypercalls.sh
> > old mode 100644
> > new mode 100755
> > --
> > 2.25.1
> >
>

I think it is fine to have this as a single patch. It is local enough
to say that we are touching all those files in a single go.

Other than that, it looks good to me.

Please state to whom you intend to send this patch.

Lukas


More information about the Linux-kernel-mentees mailing list