[Linux-kernel-mentees] [PATCH] leds: Use DEVICE_ATTR_{RW, RO, WO} macros

Joe Perches joe at perches.com
Sun Dec 13 08:40:10 UTC 2020


On Sun, 2020-12-13 at 13:48 +0530, Dwaipayan Ray wrote:
> On Sun, Dec 13, 2020 at 1:31 PM Lukas Bulwahn <lukas.bulwahn at gmail.com> wrote:
[]
> > Will you also add a checkpatch rule to identify other DEVICE_ATTR(...)
> > that can be adjusted to the refined macros, so that checkpatch informs
> > other submitters as well?
> > 
> I think a checkpatch rule for this already exists. But it cannot automatically
> rename the function names. That might be the only drawback we got.
> Probably clang-format could fix these automatically.

clang-format is not a tool to rewrite code only neaten its layout.

coccinelle _might_ be able to do this for limited cases where the
show function is in the same compilation unit/file, but even then
it would not be a trivial script.




More information about the Linux-kernel-mentees mailing list