[Linux-kernel-mentees] [PATCH] checkpatch: fix false positive for COMMIT_LOG_LONG_LINE with URLs
yashsri421 at gmail.com
Wed Dec 16 16:29:02 UTC 2020
On 16/12/20 6:27 pm, Lukas Bulwahn wrote:
> On Wed, Dec 16, 2020 at 1:54 PM Aditya <yashsri421 at gmail.com> wrote:
>> On 16/12/20 6:05 pm, Lukas Bulwahn wrote:
>>> On Wed, Dec 16, 2020 at 1:32 PM Aditya Srivastava <yashsri421 at gmail.com> wrote:
>>>> Currently checkpatch warns for long line in commit messages even for
>>>> URL lines.
>>>> An evaluation over v4.13..v5.8 showed that out of ~11000 warnings for
>>>> this class, around 790 are due to the line containing link.
>>>> E.g. running checkpatch on commit 3cde818cd02b ("ASoC: topology:
>>>> Consolidate how dtexts and dvalues are freed") reports this warning:
>>>> WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
>>>> Avoid giving users warning for character limit, instead suggest them to
>>>> prefix the URLs with "Link:"
>>> Looks good to me. This might be also a good one for a fix option.
>> I agree. Should I add the fix in this patch itself?
> No, make two patches and send them as a patch series to the mailing list.
So, I generated a list of lines, which are URLs and reported by
These occur in different forms:
1) A large part of these occur as \s*(http|https).
2) These also occur as : https, : https, etc
3) BugLink: https:// (e.g.: BugLink:
4) References: https:// (e.g.: References:
5) Link to v1: (E.g.: Link to v1:
6) Datasheet (e.g.
7) URL enclosed within brackets (E.g.:
8) Link within sentences (E.g.: suite can be found at
Among these I guess we can fix occurrences like 1st by prefixing with
"Link:". But I am not sure about the rest.
What do you think?
More information about the Linux-kernel-mentees