[Linux-kernel-mentees] [PATCH] scripts: mod: cleanup a few checkpatch.pl warnings

Dwaipayan Ray dwaipayanray1 at gmail.com
Fri Dec 18 16:37:56 UTC 2020


On Fri, Dec 18, 2020 at 9:53 PM Lukas Bulwahn <lukas.bulwahn at gmail.com> wrote:
>
>
>
> On Fri, Dec 18, 2020 at 3:36 PM Dwaipayan Ray <dwaipayanray1 at gmail.com> wrote:
>>
>> On Fri, Dec 18, 2020 at 1:29 AM Dwaipayan Ray <dwaipayanray1 at gmail.com> wrote:
>> >
>> > Cleanup some warnings reported by checkpatch.pl to make
>> > the code more in line with the kernel coding style.
>> >
>> > Signed-off-by: Dwaipayan Ray <dwaipayanray1 at gmail.com>
>> > ---
>> >  scripts/mod/file2alias.c | 156 +++++++++++++++++++++------------------
>> >  1 file changed, 83 insertions(+), 73 deletions(-)
>> >
>>
>> Lukas, If you have no problem with this cleanup patch, could I send it
>> out to the maintainers?
>>
>
> You can do that, but be aware that this might be rejected and maintainers generally dislike these "only code style fixup" patches and might not take them.
>
> I would rather like to see us making some progress on the tool to run clang-format on patches and experiment a bit more with that.
>

Okay sure enough, I will try getting a proper error handled version
of the script ready soon. I think I can try making the script operations
atomic. Like in your case when you had run it, it faulted at some
point and the sub operations after that were essentially useless.
That is something I think that could be fixed along with some style
changes.

Thank you,
Dwaipayan.


More information about the Linux-kernel-mentees mailing list