[Linux-kernel-mentees] [PATCH] net: batman-adv: Use built-in RCU list checking
madhuparnabhowmik10 at gmail.com
Sun Feb 16 15:33:24 UTC 2020
On Sun, Feb 16, 2020 at 04:22:51PM +0100, Sven Eckelmann wrote:
> On Sunday, 16 February 2020 15:47:18 CET madhuparnabhowmik10 at gmail.com wrote:
> > From: Madhuparna Bhowmik <madhuparnabhowmik10 at gmail.com>
> > hlist_for_each_entry_rcu() has built-in RCU and lock checking.
> > Pass cond argument to hlist_for_each_entry_rcu() to silence
> > false lockdep warnings when CONFIG_PROVE_RCU_LIST is enabled
> > by default.
> > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10 at gmail.com>
> > ---
> > net/batman-adv/translation-table.c | 12 ++++++++----
> > 1 file changed, 8 insertions(+), 4 deletions(-)
> Added with alignment and line length codingstyle fixes .
> Can you tell us how you've identified these four hlist_for_each_entry_rcu?
Thank you for the fixes.
The other hlist_for_each_entry_rcu() are used under the protection of
rcu_read_lock(). We only need to pass the cond when
hlist_for_each_entry_rcu() is used under a
different lock (not under rcu_red_lock()) because according to the current scheme a lockdep splat
is generated when hlist_for_each_entry_rcu() is used outside of
rcu_read_lock() or the lockdep condition (the cond argument) evaluates
to false. So, we need to pass this cond when it is used under the
protection of spinlock or mutex etc. and not required if rcu_read_lock()
>  https://git.open-mesh.org/linux-merge.git/commit/967709ec53a07d1bccbc3716f7e979d3103bd7c5
More information about the Linux-kernel-mentees