[Linux-kernel-mentees] [PATCH] net: batman-adv: Use built-in RCU list checking

Sven Eckelmann sven at narfation.org
Sun Feb 16 16:17:36 UTC 2020

On Sunday, 16 February 2020 16:52:44 CET Madhuparna Bhowmik wrote:
> > I understand this part. I was asking how you've identified them. Did you use 
> > any tool for that? coccinelle, sparse, ...
> Not really, I did it manually by inspecting each occurence.

In that case, I don't understand why you didn't convert the occurrences from 
hlist_for_each_entry_rcu to hlist_for_each_entry [1]. Because a manual
inspection should have noticed that there will always be the lock around
these ones.

KInd regards,

[1] https://www.kernel.org/doc/html/v5.6-rc1/RCU/whatisRCU.html#analogy-with-reader-writer-locking
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.linuxfoundation.org/pipermail/linux-kernel-mentees/attachments/20200216/fce5cd06/attachment-0001.sig>

More information about the Linux-kernel-mentees mailing list