[Linux-kernel-mentees] [PATCH 1/1] media: dvb_dummy_tuner: implement driver skeleton

Daniel W. S. Almeida dwlsalmeida at gmail.com
Thu Jan 9 21:00:01 UTC 2020


Hi Shuah, thank you for you input!


>
> Looks like there is more code to be added to register/unregister 

Just to be clear, attach() is missing, but register / unregister belong 
in the bridge driver. Is this correct?


>
> Please add more detail here on what this driver does. What this
> driver is used for and so on.
>
>
> Samehere. Give more details on what this driver does. Add enough detail
> to help users decide why they should enable it or not. 
>
> General practice is the following.
>
> Copyright (c) 2020 Daniel W. S. Almeida <dwlsalmeida at gmail.com>

> Please add details about the driver similar to the .c file. 

OK.


Thanks

- Daniel




More information about the Linux-kernel-mentees mailing list