[Linux-kernel-mentees] [PATCH v2] media: dvb_dummy_tuner: implement driver skeleton

Daniel W. S. Almeida dwlsalmeida at gmail.com
Mon Jan 13 18:23:02 UTC 2020


Hi Greg,

I am working on v3. Would you mind clarifying this?


>> + *
>> + * The virtual DVB test driver serves as a reference DVB driver and helps
>> + * validate the existing APIs in the media subsystem. It can also aid developers
>> + * working on userspace applications.
>> + *
>> + * This dummy tuner should support common TV standards such as DVB-T/T2/S/S2,
>> + * ISDB-T and ATSC when completed.
>> + *
>> + * Copyright (c) 2020 Daniel W. S. Almeida <dwlsalmeida at gmail.com>
> Normally this is the first comment line above in this block.
>

Just so we're clear, do you mean this? e.g.:

+ * Copyright (c) 2020 Daniel W. S. Almeida <dwlsalmeida at gmail.com>
+ *
+ * The virtual DVB test driver serves as a reference DVB driver and helps
+ * validate the existing APIs in the media subsystem. It can also aid developers
+ * working on userspace applications.
+ *
+ * This dummy tuner should support common TV standards such as DVB-T/T2/S/S2,
+ * ISDB-T and ATSC when completed.
+ *


> Not the same license as your .c file?  Odd :(

Oops! :(


> If you keep this file, same comments as above for the comment block, but
> really, you don't need this .h file at all, just drop it.

OK.


- Daniel




More information about the Linux-kernel-mentees mailing list