[Linux-kernel-mentees] [PATCH] net: xen-netbank: hash.c: Use built-in RCU list checking
madhuparnabhowmik04 at gmail.com
Wed Jan 15 15:46:21 UTC 2020
On Wed, Jan 15, 2020 at 8:34 PM Wei Liu <wei.liu at kernel.org> wrote:
> On Wed, Jan 15, 2020 at 07:36:38PM +0530, Madhuparna Bhowmik wrote:
> > > The surrounding code makes it pretty clear that the lock is already
> > > by the time list_for_each_entry_rcu is called, yet the checking
> > > in lockdep_is_held is not trivial, so I'm afraid I don't consider this
> > > strict improvement over the existing code.
> > >
> > > Actually, we want to make CONFIG_PROVE_LIST_RCU enabled by default.
> I think you meant CONFIG_PROVE_RCU_LIST.
> I am sorry about this. Yes, I meant CONFIG_PROVE_RCU_LIST.
> And if the cond argument is not passed when the usage of
> > list_for_each_entry_rcu()
> > is outside of rcu_read_lock(), it will lead to a false positive.
> > Therefore, I think this patch is required.
> Fair enough.
> Thank you,
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Linux-kernel-mentees