[Linux-kernel-mentees] [PATCH] parsing_hacks: Add bool to list of known typedefs

[Julia Lawall]

On Tue, 21 Jan 2020, Jaskaran Singh wrote:

> On Tue, 2020-01-21 at 06:20 +0000, Julia Lawall wrote:
> >
> > On Sun, 19 Jan 2020, Jaskaran Singh wrote:
> >
> > > bool is widely used in the Linux kernel. Certain cases of
> > > parsing_hacks.ml would mislabel bool.
> > >
> > > Add bool to the list of known typedefs.
> > >
> > > Stats of --parse-c on Linux v5.5-rc4 are as follows:
> > >
> > > Before:
> > >
> > >   nb good = 18956150,  nb passed = 134062 =========> 0.70% passed
> > >
> > > After:
> > >
> > >   nb good = 18956150,  nb passed = 134073 =========> 0.70% passed
> >
> > Why did nb passed increase?  These are tokens that will not be able
> > to be
> > transformed by a semantic patch.
> >
>
> I suspect it's instances of nokprobe_inline in
> linux/kernel/trace/trace_kprobe.c. They're marked as CppMacro.

OK, that looks ok.  Could you update the log messages with that
information?

thanks,
julia


>
> Here's results from my diff:
>
> 20402,20406c20288,20294
> < passed:bool
> < passed:bool
> < passed:bool
> < passed:bool
> < passed:bool
> ---
> > passed:nokprobe_inline
> > passed:nokprobe_inline
> > passed:nokprobe_inline
> > passed:nokprobe_inline
> > passed:nokprobe_inline
> > passed:nokprobe_inline
> > passed:nokprobe_inline
> 20407a20296,20297
> > passed:nokprobe_inline
> > passed:nokprobe_inline
> 20408a20299,20300
> > passed:nokprobe_inline
> > passed:nokprobe_inline
> 20409a20302,20303
> > passed:nokprobe_inline
> > passed:nokprobe_inline
> 20410a20305,20306
> > passed:nokprobe_inline
> > passed:nokprobe_inline
>
> Cheers,
> Jaskaran.
>
> > julia
> >
> > > Signed-off-by: Jaskaran Singh <jaskaransingh7654321 at gmail.com>
> > > ---
> > > The above diff has been obtained after applying
> > > https://www.mail-archive.com/cocci@systeme.lip6.fr/msg06706.html
> > >
> > >  parsing_c/parsing_hacks.ml | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/parsing_c/parsing_hacks.ml
> > > b/parsing_c/parsing_hacks.ml
> > > index 685a4908..5e3301a0 100644
> > > --- a/parsing_c/parsing_hacks.ml
> > > +++ b/parsing_c/parsing_hacks.ml
> > > @@ -61,7 +61,7 @@ let is_known_typdef =
> > >        | "u_char"   | "u_short"  | "u_int"  | "u_long"
> > >        | "u8" | "u16" | "u32" | "u64"
> > >        | "s8"  | "s16" | "s32" | "s64"
> > > -      | "__u8" | "__u16" | "__u32"  | "__u64"
> > > +      | "__u8" | "__u16" | "__u32"  | "__u64" | "bool"
> > >          -> true
> > >
> > >        | "acpi_handle"
> > > --
> > > 2.21.1
> > >
> > >
>
>