[Linux-kernel-mentees] [PATCH 0/2] lspci: Add lspci support to decode AIDA64 and dmesg log files
mj at ucw.cz
Tue Jan 21 21:00:41 UTC 2020
> Add lspci support to decode AIDA64 log files and dmesg log files with
> "pci=earlydump" parameter to output PCI configuration space information.
> Patch 1: Add lspci support to decode AIDA64 log file.
> AIDA64 log file included in patch for testing. Use the following
> command to run:
> lspci -F tests/aida64-dump
> Patch 2: Add lspci support to decode dmesg log file with
> "pci=earlydump" parameter.
> dmesg log file with "pci=earlydump" included in patch for
> testing. Use the following command to run:
> lspci -F tests/dmesg-dump
Generally, I like the idea of adding these two file formats
to the dump back-end.
However, combining parsers of all three formats to a single block
of code looks pretty scary. With a couple of formats more, this would
become an unmaintable mess.
I would prefer separate parsers and explicit selection of input format.
If you want any help with how to integrate that to libpci/lspci, please
let me know.
Also, please document which formats are supported.
Have a nice fortnight
Martin `MJ' Mareš <mj at ucw.cz> http://mj.ucw.cz/
United Computer Wizards, Prague, Czech Republic, Europe, Earth, Universe
"I think it's a new feature. Don't tell anyone it was an accident. :-)" -- Larry Wall
More information about the Linux-kernel-mentees