[Linux-kernel-mentees] [PATCH] checkpatch: Adjust spelling check false positive

Lukas Bulwahn lukas.bulwahn at gmail.com
Fri Jul 10 21:47:01 UTC 2020

>> For Issue 5: Can you provide me (and the CC: the list) the list of
>> false positives (the commit hashes) you found for issue 5 on
> Here are the commit hashes for which the warning is issued:
> 54505a1e2083
> 75d75b7a4d54
> 8084c99b9af6
> bfdaf029c9c9
> dfd402a4c4ba
>> Can you also provide a short rationale/explanation for
>> each case that you considered a false positive?
> In each case the `EXPORT_SYMBOL()` is correctly written and the
variable/function to be exported
> is also inside the parentheses, still, we get the warning. Please let me
know if I am wrong here.

I checked those warnings. Some of the patches are good cases to check if we
can improve the heuristics on EXPORT_SYMBOL().

E.g., commit bfdaf029c9c9 ("ia64: turn csum_partial_copy_from_user() into
csum_and_copy_from_user()") looks sound to me, and checkpatch.pl should not
really warn about that.

Mrinal, maybe you can find out why checkpatch.pl believes that this case is
wrong and needs to be warned about?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxfoundation.org/pipermail/linux-kernel-mentees/attachments/20200710/8c8089c0/attachment.html>

More information about the Linux-kernel-mentees mailing list