[Linux-kernel-mentees] [PATCH 5/11 RFC] PCI: pciehp: Make "Power On" the default
refactormyself at gmail.com
Fri Jul 10 21:42:12 UTC 2020
On 7/10/20 2:14 AM, Bjorn Helgaas wrote:
> On Mon, Jul 06, 2020 at 11:31:15AM +0200, Saheed Olayemi Bolarinwa wrote:
>> From: Bolarinwa Olayemi Saheed <refactormyself at gmail.com>
>> The default case of the switch statement is redundant since
>> PCI_EXP_SLTCTL_PCC is only a single bit. pcie_capability_read_word()
>> currently causes "On" value to be set if it fails. Patch 11/11
>> changes the behaviour of pcie_capability_read_word() so on falure the
>> "Off" value will be set.
> Split this into two patches. The removal of the default case should
> be in its own patch to make it trivial to review.
Thank you for the review. It is now split into two in the version 3
which I just sent.
More information about the Linux-kernel-mentees