[Linux-kernel-mentees] [PATCH] checkpatch: Fix the usage of capture group ( ... )
mrinalmni at gmail.com
Sun Jul 12 05:18:37 UTC 2020
On Sun, Jul 12, 2020 at 12:44 AM Lukas Bulwahn <lukas.bulwahn at gmail.com>
> On Sat, Jul 11, 2020 at 5:44 PM Mrinal Pandey <mrinalmni at gmail.com> wrote:
>> The usage of "capture group (...)" in the immediate condition after `&&`
>> results in `$1` being uninitialized. This eventually crashes the script.
> It does not really crash it, right? It just emits a warning.
Yes. I will modify the line accordingly.
>> Fix this by placing the capture group in the condition before `&&`.
>> Thus, `$1` can be initialized to the text it matches thereby setting it
>> to the desired and required value.
> Maybe you can look when this bug was introduced?
The bug was first introduced with the commit `e518e9a59ec3` when the block
added to the script. It has been like that since then.
Should I add this detail too in the commit message?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Linux-kernel-mentees