[Linux-kernel-mentees] [PATCH 4/14 v3] iwlegacy: Check the return value of pcie_capability_read_*()
kvalo at codeaurora.org
Wed Jul 15 16:47:52 UTC 2020
"Saheed O. Bolarinwa" <refactormyself at gmail.com> wrote:
> From: Bolarinwa Olayemi Saheed <refactormyself at gmail.com>
> On failure pcie_capability_read_dword() sets it's last parameter, val
> to 0. However, with Patch 14/14, it is possible that val is set to ~0 on
> failure. This would introduce a bug because (x & x) == (~0 & x).
> This bug can be avoided without changing the function's behaviour if the
> return value of pcie_capability_read_dword is checked to confirm success.
> Check the return value of pcie_capability_read_dword() to ensure success.
> Suggested-by: Bjorn Helgaas <bjorn at helgaas.com>
> Signed-off-by: Bolarinwa Olayemi Saheed <refactormyself at gmail.com>
Patch applied to wireless-drivers-next.git, thanks.
9018fd7f2a73 iwlegacy: Check the return value of pcie_capability_read_*()
More information about the Linux-kernel-mentees