[Linux-kernel-mentees] [Intel-wired-lan] [PATCH v1 2/5] igbvf: netdev: use generic power management

[Brown, Aaron F]

> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Vaibhav Gupta
> Sent: Monday, June 29, 2020 2:30 AM
> To: Bjorn Helgaas <helgaas at kernel.org>; Bjorn Helgaas
> <bhelgaas at google.com>; bjorn at helgaas.com; Vaibhav Gupta
> <vaibhav.varodek at gmail.com>; David S. Miller <davem at davemloft.net>;
> Jakub Kicinski <kuba at kernel.org>; Kirsher, Jeffrey T
> <jeffrey.t.kirsher at intel.com>
> Cc: Vaibhav Gupta <vaibhavgupta40 at gmail.com>; netdev at vger.kernel.org;
> linux-kernel at vger.kernel.org; intel-wired-lan at lists.osuosl.org;
> skhan at linuxfoundation.org; linux-kernel-mentees at lists.linuxfoundation.org
> Subject: [Intel-wired-lan] [PATCH v1 2/5] igbvf: netdev: use generic power
> management
> 
> Remove legacy PM callbacks and use generic operations. With legacy code,
> drivers were responsible for handling PCI PM operations like
> pci_save_state(). In generic code, all these hre andled by PCI core.
> 
> The generic suspend() and resume() are called at the same point the legacy
> ones were called. Thus, it does not affect the normal functioning of the
> driver.
> 
> __maybe_unused attribute is used with .resume() but not with .suspend(), as
> .suspend() is calleb by .shutdown().
> 
> Compile-tested only.
> 
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40 at gmail.com>
> ---
>  drivers/net/ethernet/intel/igbvf/netdev.c | 37 +++++------------------
>  1 file changed, 8 insertions(+), 29 deletions(-)
> 

Tested-by: Aaron Brown <aaron.f.brown at intel.com>