[Linux-kernel-mentees] [PATCH] lib: Convert test_uuid.c to KUnit

Brendan Higgins brendanhiggins at google.com
Fri Jul 31 20:53:34 UTC 2020


On Fri, Jul 31, 2020 at 3:02 AM Arpitha Raghunandan <98.arpi at gmail.com> wrote:
>
> On 31/07/20 11:20 am, Brendan Higgins wrote:
> > On Thu, Jul 30, 2020 at 5:18 AM Arpitha Raghunandan <98.arpi at gmail.com> wrote:
> >>
> >> Converts test lib/test_uuid.c to KUnit
> >
> > Can you add some more detail to the commit message? Maybe link to
> > KUnit and say something about why this change is beneficial.
> >
> Sure, I will make this change.
> >> Signed-off-by: Arpitha Raghunandan <98.arpi at gmail.com>
> >
> > Change mostly looks good to me.
> > Thank you for the review.
>
> On failure, the original test calls another function which prints a detailed error. I removed it when converting to KUnit. Is this required?

I think that's probably Andy's call. Do you mind calling out the
segment of code in question?


More information about the Linux-kernel-mentees mailing list