[Linux-kernel-mentees] [RFC, WIP, v6 02/10] media: vidtv: implement a tuner driver

Daniel W. S. Almeida dwlsalmeida at gmail.com
Wed Jun 3 17:19:12 UTC 2020


Hi Shuah, thanks for reviewing this!

>> From: "Daniel W. S. Almeida" <dwlsalmeida at gmail.com>
> 
> Are you using git send-email to send patches. Why do have this
> From line in here? Same comment on all other patches in this series.

I am using 'git format-patch --to=[...] --cc=[...]' and then 'git send-email'.

Git format-patch usually adds these two lines for every patch it generates:
  1 From f966b0ea574a36b96ddfb8a8a716b174bc150eba Mon Sep 17 00:00:00 2001
  2 From: "Daniel W. S. Almeida" <dwlsalmeida at gmail.com>

I have no idea whether these are necessary, so I just leave them there :)
The first line is specially weird.


As for this:

>> +	switch (c->delivery_system) {
> 
> Add indetation for the below:
> 
>> +	case SYS_DVBT:
>> +	case SYS_DVBT2:
>> +		valid_freqs = config.vidtv_valid_dvb_t_freqs;
>> +		array_sz    = ARRAY_SIZE(config.vidtv_valid_dvb_t_freqs);
>> +		break;

I am not sure I understand. Indenting the case statements leads to a
checkpatch complaint: 

>SWITCH_CASE_INDENT_LEVEL: switch and case should be at the
>same indent

And the actual statements under 'case' are already indented.

Thanks
- Daniel


More information about the Linux-kernel-mentees mailing list