[Linux-kernel-mentees] [PATCH v2 6/8] PCI/AER: Convert PCIBIOS_* errors to generic -E* errors

refactormyself at gmail.com refactormyself at gmail.com
Mon Jun 15 07:32:23 UTC 2020

From: Bolarinwa Olayemi Saheed <refactormyself at gmail.com>

pci_enable_pcie_error_reporting() return PCIBIOS_ error codes which were
passed on down the call heirarchy from PCIe capability accessors.

PCIBIOS_ error codes have positive values. Passing on these values is
inconsistent with functions which return only a negative value on failure.

Before passing on the return value of PCIe capability accessors, call
pcibios_err_to_errno() to convert any positive PCIBIOS_ error codes to
negative generic error values.

Suggested-by: Bjorn Helgaas <bjorn at helgaas.com>
Signed-off-by: Bolarinwa Olayemi Saheed <refactormyself at gmail.com>
 drivers/pci/pcie/aer.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
index f4274d301235..95d480a52078 100644
--- a/drivers/pci/pcie/aer.c
+++ b/drivers/pci/pcie/aer.c
@@ -349,13 +349,17 @@ bool aer_acpi_firmware_first(void)
 int pci_enable_pcie_error_reporting(struct pci_dev *dev)
+	int rc;
 	if (pcie_aer_get_firmware_first(dev))
 		return -EIO;
 	if (!dev->aer_cap)
 		return -EIO;
-	return pcie_capability_set_word(dev, PCI_EXP_DEVCTL, PCI_EXP_AER_FLAGS);
+	rc = pcie_capability_set_word(dev, PCI_EXP_DEVCTL, PCI_EXP_AER_FLAGS);
+	return pcibios_err_to_errno(rc);

More information about the Linux-kernel-mentees mailing list