[Linux-kernel-mentees] [EXT] [PATCH v1] bnx2x: use generic power management

Sudarsana Reddy Kalluru skalluru at marvell.com
Fri Jun 26 10:15:52 UTC 2020


> -----Original Message-----
> From: Igor Russkikh <irusskikh at marvell.com>
> Sent: Thursday, June 25, 2020 10:16 PM
> To: Vaibhav Gupta <vaibhavgupta40 at gmail.com>; Bjorn Helgaas
> <helgaas at kernel.org>; Bjorn Helgaas <bhelgaas at google.com>;
> bjorn at helgaas.com; Vaibhav Gupta <vaibhav.varodek at gmail.com>; David S.
> Miller <davem at davemloft.net>; Jakub Kicinski <kuba at kernel.org>; Ariel Elior
> <aelior at marvell.com>; Sudarsana Reddy Kalluru <skalluru at marvell.com>; GR-
> everest-linux-l2 <GR-everest-linux-l2 at marvell.com>
> Cc: netdev at vger.kernel.org; linux-kernel at vger.kernel.org; linux-kernel-
> mentees at lists.linuxfoundation.org; skhan at linuxfoundation.org
> Subject: Re: [EXT] [PATCH v1] bnx2x: use generic power management
> 
> 
> 
> On 24/06/2020 8:51 pm, Vaibhav Gupta wrote:
> > External Email
> >
> > ----------------------------------------------------------------------
> > With legacy PM, drivers themselves were responsible for managing the
> > device's power states and takes care of register states.
> >
> > After upgrading to the generic structure, PCI core will take care of
> > required tasks and drivers should do only device-specific operations.
> >
> > The driver was also calling bnx2x_set_power_state() to set the power
> > state of the device by changing the device's registers' value. It is
> > no more needed.
> >
> > Compile-tested only.
> >
> > Signed-off-by: Vaibhav Gupta <vaibhavgupta40 at gmail.com>
> > ---
> >  drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c  | 15 ++++++---------
> > drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h  |  4 +---
> > drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c |  3 +--
> >  3 files changed, 8 insertions(+), 14 deletions(-)
> 
> Acked-by: Igor Russkikh <irusskikh at marvell.com>
> 
> Sudarsana, could you please give it a short sanity test and report back?
> 
> Thanks,
>   Igor

I have run the basic sanity test with these changes in the driver, didn’t see any issues.

Thanks,
Sudarsana


More information about the Linux-kernel-mentees mailing list