[Linux-kernel-mentees] [PATCH v2 3/8] IB/hfi1: Convert PCIBIOS_* errors to generic -E* errors

Dennis Dalessandro dennis.dalessandro at intel.com
Mon Jun 29 20:22:58 UTC 2020


On 6/15/2020 3:32 AM, refactormyself at gmail.com wrote:
> From: Bolarinwa Olayemi Saheed <refactormyself at gmail.com>
> 
> restore_pci_variables() and save_pci_variables() return PCIBIOS_ error
> codes from PCIe capability accessors.
> 
> PCIBIOS_ error codes have positive values. Passing on these values is
> inconsistent with functions which return only a negative value on failure.
> 
> Before passing on the return value of PCIe capability accessors, call
> pcibios_err_to_errno() to convert any positive PCIBIOS_ error codes to
> negative generic error values.
> 
> Fix redundant initialisation.
> 
> Suggested-by: Bjorn Helgaas <bjorn at helgaas.com>
> Signed-off-by: Bolarinwa Olayemi Saheed <refactormyself at gmail.com>

Looks like we may have had a problem when calling 
pci_read_config_dword() from the init dd path and doing a check for < 0 
to bail. So this looks like goodness to me.

Reviewed-by: Dennis Dalessandro <dennis.dalessandro at intel.com>


More information about the Linux-kernel-mentees mailing list