[Linux-kernel-mentees] [PATCH 2/2] xarray: Add missing blank line after declaration

Vitor Massaru Iha vitor at massaru.org
Wed Mar 18 03:01:17 UTC 2020


Hi Matthew,

On Tue, 2020-03-17 at 18:55 -0700, Matthew Wilcox wrote:
> On Tue, Mar 17, 2020 at 10:43:03PM -0300, Vitor Massaru Iha wrote:
> > @@ -1624,6 +1624,7 @@ static inline unsigned int
> > xas_find_chunk(struct xa_state *xas, bool advance,
> >  	if (XA_CHUNK_SIZE == BITS_PER_LONG) {
> >  		if (offset < XA_CHUNK_SIZE) {
> >  			unsigned long data = *addr & (~0UL << offset);
> > +
> >  			if (data)
> >  				return __ffs(data);
> >  		}
> 
> Do you seriously think this makes the function in any way more
> legible?

Sorry. I was in doubt whether it would actually improve. I did some
research in older patches and I found something like this.





More information about the Linux-kernel-mentees mailing list