[Linux-kernel-mentees] [RESEND] kunit: use --build_dir=.kunit as default

Vitor Massaru Iha vitor at massaru.org
Tue May 26 02:27:00 UTC 2020


On Mon, 2020-05-25 at 22:52 -0300, Vitor Massaru Iha wrote:
> Hi Shuah,
> 
> On Fri, 2020-05-22 at 16:40 -0600, shuah wrote:
> > On 4/16/20 5:11 PM, Brendan Higgins wrote:
> > > On Tue, Apr 14, 2020 at 4:09 PM Vitor Massaru Iha <
> > > vitor at massaru.org> wrote:
> > > > To make KUnit easier to use, and to avoid overwriting object
> > > > and
> > > > .config files, the default KUnit build directory is set to
> > > > .kunit
> > > > 
> > > >   * Related bug: 
> > > > https://bugzilla.kernel.org/show_bug.cgi?id=205221
> > > > 
> > > > Signed-off-by: Vitor Massaru Iha <vitor at massaru.org>
> > > 
> > > Reviewed-by: Brendan Higgins <brendanhiggins at google.com>
> > > 
> > 
> > Applied the patch to kselftest/kunit on top of
> > 
> > 45ba7a893ad89114e773b3dc32f6431354c465d6
> > kunit: kunit_tool: Separate out config/build/exec/parse
> > 
> > from David's work resolving merge conflicts. Please check if it is
> > sane.
> > 
> > thanks,
> > -- Shuah
> 
> The kunit branch had some problems related to identation. KUnit's
> code
> has mixed identation, and with that, in conflict correction, it ended
> up breaking python.
> 
> In addition I found a bug: related to the creation of the
> .kunitconfig
> file inside the default build directory.

This is actually related to the other patch "kunit: use KUnit defconfig
by default"


>  Should I send the patch again?
> Or do I make a bugfix patch?
> 
> BR,
> Vitor
> 



More information about the Linux-kernel-mentees mailing list