[Linux-kernel-mentees] [PATCH v4 25/29] scsi: mvumi: Drop PCI Wakeup calls from .resume

Vaibhav Gupta vaibhavgupta40 at gmail.com
Mon Nov 2 16:47:26 UTC 2020

The driver calls pci_enable_wake(...., false) in mvumi_resume(), and
there is no corresponding pci_enable_wake(...., true) in mvumi_suspend().
Either it should do enable-wake the device in .suspend() or should not
invoke pci_enable_wake() at all.

Concluding that this driver doesn't support enable-wake and PCI core calls
pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from

Signed-off-by: Vaibhav Gupta <vaibhavgupta40 at gmail.com>
 drivers/scsi/mvumi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c
index 0354898d7cac..7cd9c70e32dd 100644
--- a/drivers/scsi/mvumi.c
+++ b/drivers/scsi/mvumi.c
@@ -2595,7 +2595,6 @@ static int __maybe_unused mvumi_resume(struct pci_dev *pdev)
 	mhba = pci_get_drvdata(pdev);
 	pci_set_power_state(pdev, PCI_D0);
-	pci_enable_wake(pdev, PCI_D0, 0);
 	ret = pci_enable_device(pdev);

More information about the Linux-kernel-mentees mailing list