[Linux-kernel-mentees] [PATCH v2] checkpatch: improve email parsing

Joe Perches joe at perches.com
Tue Nov 3 07:28:06 UTC 2020

On Tue, 2020-11-03 at 11:28 +0530, Dwaipayan Ray wrote:
> On Tue, Nov 3, 2020 at 11:18 AM Dwaipayan Ray <dwaipayanray1 at gmail.com> wrote:
> > 
> > checkpatch doesn't report warnings for many common mistakes
> > in emails. Some of which are trailing commas and incorrect
> > use of email comments.
> > 
> > At the same time several false positives are reported due to
> > incorrect handling of mail comments. The most common of which
> > is due to the pattern:
> > 
> > <stable at vger.kernel.org> # X.X
> > 
> > Improve email parsing mechanism in checkpatch.
> > 
> > What is added:
> > 
> > - Support for multiple name/address comments.
> > - Improved handling of quoted names.
> > - Sanitize improperly formatted comments.
> > - Sanitize trailing semicolon or dot after email.
> What do you think? Should warnings for the names which should
> be quoted be reported considering this result?

Clearly the quote suggestion is unnecessary.

I think that "cc: stable@(?:vger\.)?kernel\.org" should be
treated differently from other forms of invalid/odd address lines.

My suggestion is that the case insensitive form of

Cc: stable at vger.kernel.org

or only another similar case insensitive forms with a
# comment separator like

Cc: <stable at vger.kernel.org> # some comment

be acceptable for stable.

All other forms with stable@ should emit some message.

And other <foo>-by: and cc: addresses should only have a form like

Signed-off-by: "Full.Name" (possible comment) <email at domain.tld>
Signed-off-by: Full Name (possible comment) <email at domain.tld>


and any additional content after .tld in the email address be flagged
with some message like "unexpected content after email address" rather
than "might be better as".

What do you think best?

More information about the Linux-kernel-mentees mailing list