[Linux-kernel-mentees] [PATCH] checkpatch: add fix option for COMMIT_LOG_LONG_LINE

Lukas Bulwahn lukas.bulwahn at gmail.com
Tue Nov 3 10:41:14 UTC 2020

On Tue, Nov 3, 2020 at 9:38 AM Aditya <yashsri421 at gmail.com> wrote:
> > On 2/11/20 12:55 pm, Lukas Bulwahn wrote:
> >>
> >> Or to prioritize another issue and possiblity for fix rules.
> >>
> >> You can see that there are potentially some good options for fixes around
> >> the tags and sign-offs Dwaipayan has investigated.
> >>
> Sir, I am working on BAD_SIGN_OFF, which occurs in multiple variants,
> for eg.
> 1) WARNING:BAD_SIGN_OFF: Co-developed-by: should not be used to
> attribute nominal patch author '"Zhang, Jun" <jun.zhang at intel.com>'

I think the fix here might be to drop the Co-developed-by: line, right?

Can you confirm this fix on your evaluation?

> 2) WARNING:BAD_SIGN_OFF: email address '"Matthew Wilcox (Oracle)"
> <willy at infradead.org>' might be better as 'Matthew Wilcox (Oracle)
> <willy at infradead.org>'

I think Dwaipayan and Joe are discussing the proper handling of
quotes. I suggest to understand the resolution that Dwaipayan and Joe
are working out before thinking about a fix for this option. They
might decide that only a few specific cases should be warned about or
not at all in case of quote mismatches.

> 3) WARNING:BAD_SIGN_OFF: Duplicate signature
> etc.

I do not see the fix option for this case 3; the duplicate signatures
are mostly due to the integration Signed-off-by trail.

> Should I answer all these variants in one patch?
> Thanks
> Aditya

More information about the Linux-kernel-mentees mailing list