[Linux-kernel-mentees] [PATCH] checkpatch: add fix option for MISSING_SIGN_OFF
lukas.bulwahn at gmail.com
Mon Nov 9 14:45:27 UTC 2020
On Mon, Nov 9, 2020 at 3:33 PM Aditya <yashsri421 at gmail.com> wrote:
> On 9/11/20 7:10 pm, Lukas Bulwahn wrote:
> > On Mo., 9. Nov. 2020 at 14:10, Aditya Srivastava <yashsri421 at gmail.com>
> > wrote:
> >> Currently checkpatch warns us if there is no 'Signed-off-by' line
> >> for the patch.
> >> E.g., running checkpatch on commit f68e7927212f ("Revert
> >> "powerpc/book3s32: Reorder _PAGE_XXX flags to simplify TLB handling"")
> >> reports this error:
> >> ERROR: Missing Signed-off-by: line(s)
> >> Provide a fix by adding a Signed-off-by line corresponding to the author
> >> of the patch before the start of diff(s)
> > Can you please provide an evaluation first?
> > As far as remember, the fix is often not to add a Signed-off-by: tag but it
> > requires something completely different.
> I have generated the 'git logs' of the commits causing
> MISSING_SIGN_OFF at:
> Actually this fix was suggested by Joe at:
Yes I know. Now look at the reports.
The rc and release commit tags do not get a Signed-off-by
intentionally. Other than that, reverts (for reverts is probably best
to explain how to do a revert... so that a sign-off-by is included)
More information about the Linux-kernel-mentees