[Linux-kernel-mentees] [PATCH] checkpatch: avoid COMMIT_LOG_LONG_LINE warning for signature tags

Lukas Bulwahn lukas.bulwahn at gmail.com
Wed Nov 11 19:54:33 UTC 2020


On Wed, Nov 11, 2020 at 8:35 PM Aditya <yashsri421 at gmail.com> wrote:
>
> On 12/11/20 12:56 am, Lukas Bulwahn wrote:
> > On Wed, Nov 11, 2020 at 8:20 PM Aditya Srivastava <yashsri421 at gmail.com> wrote:
> >>
> >> Currently checkpatch warns us for long lines in commits even for
> >> signature tag lines.
> >>
> >> E.g., running checkpatch on commit 4bbdfe25600c ("IB/opa_vnic: Properly
> >> clear Mac Table Digest") reports this warning:
> >>
> >> WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
> >> Reviewed-by: Niranjana Vishwanathapura <niranjana.vishwanathapura at intel.com>
> >>
> >> This is an example of false positive. Provide a fix by excluding
> >> signature tag lines from this class of warning.
> >>
> >> Signed-off-by: Aditya Srivastava <yashsri421 at gmail.com>
> >> ---
> >>  scripts/checkpatch.pl | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> >> index ac7e5ac80b58..1d257b1f4a4f 100755
> >> --- a/scripts/checkpatch.pl
> >> +++ b/scripts/checkpatch.pl
> >> @@ -2963,6 +2963,8 @@ sub process {
> >>                                         # filename then :
> >>                       $line =~ /^\s*(?:Fixes:|Link:)/i ||
> >>                                         # A Fixes: or Link: line
> >> +                     $line =~ /^\s*(?:$signature_tags)/ ||
> >> +                                       # signature tag line
> >
> > Can you simply add this check to the expression above?
> >
> Yes, we can do it. But then the match will become case insensitive
> (because of presence of '/i'). Should I do it irrespective?
>

I see. Then keep it as is and start the evaluation.

Lukas

> Thanks
> Aditya
>
> >>                       $commit_log_possible_stack_dump)) {
> >>                         WARN("COMMIT_LOG_LONG_LINE",
> >>                              "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
> >> --
> >> 2.17.1
> >>
>


More information about the Linux-kernel-mentees mailing list