[Linux-kernel-mentees] [PATCH RFC] checkpatch: add new cases to commit handling

Dwaipayan Ray dwaipayanray1 at gmail.com
Thu Nov 12 16:08:59 UTC 2020


On Thu, Nov 12, 2020 at 9:19 PM Lukas Bulwahn <lukas.bulwahn at gmail.com> wrote:
>
> On Thu, Nov 12, 2020 at 4:43 PM Dwaipayan Ray <dwaipayanray1 at gmail.com> wrote:
> >
> > Commit extraction in checkpatch fails in some cases.
> > One of the most common false positives is a split line
> > between "commit" and the git SHA of the commit.
> >
> > Improve commit handling to reduce false positives.
> >
> > Improvements:
> > - handle split line between commit and git SHA of commit.
> > - fix handling of split commit description.
> >
>
> Looks good. Do we have a quick evaluation on that?
>

Yes, I had a previous warning dump for 50k commits
from v5.4.

Earlier, no. of GIT_COMMIT ID errors was: 1032.
After the patch it is: 897.

I haven't checked which ones exactly were fixed though.
I think I could extract those commit references just to be
sure.

Thanks,
Dwaipayan.


More information about the Linux-kernel-mentees mailing list