[Linux-kernel-mentees] [PATCH RFC] checkpatch: add new cases to commit handling

Lukas Bulwahn lukas.bulwahn at gmail.com
Thu Nov 12 16:15:47 UTC 2020


On Thu, Nov 12, 2020 at 5:09 PM Dwaipayan Ray <dwaipayanray1 at gmail.com> wrote:
>
> On Thu, Nov 12, 2020 at 9:19 PM Lukas Bulwahn <lukas.bulwahn at gmail.com> wrote:
> >
> > On Thu, Nov 12, 2020 at 4:43 PM Dwaipayan Ray <dwaipayanray1 at gmail.com> wrote:
> > >
> > > Commit extraction in checkpatch fails in some cases.
> > > One of the most common false positives is a split line
> > > between "commit" and the git SHA of the commit.
> > >
> > > Improve commit handling to reduce false positives.
> > >
> > > Improvements:
> > > - handle split line between commit and git SHA of commit.
> > > - fix handling of split commit description.
> > >
> >
> > Looks good. Do we have a quick evaluation on that?
> >
>
> Yes, I had a previous warning dump for 50k commits
> from v5.4.
>
> Earlier, no. of GIT_COMMIT ID errors was: 1032.
> After the patch it is: 897.
>
Impact-wise that sounds like a good contribution to checkpatch.

> I haven't checked which ones exactly were fixed though.
> I think I could extract those commit references just to be
> sure.
>

Let us create a quick list of those; it will probably just take a few
minutes to check them. And Joe is probably going to ask for an
independent check anyway :)

Add the summary of the evaluation to the commit message and then let
us send this patch to Joe and lkml.

Lukas


More information about the Linux-kernel-mentees mailing list