[Linux-kernel-mentees] [PATCH v2] checkpatch: avoid COMMIT_LOG_LONG_LINE warning for signature tags

Aditya Srivastava yashsri421 at gmail.com
Thu Nov 12 19:58:40 UTC 2020

Currently checkpatch warns us for long lines in commits even for
signature tag lines.

Generally these lines exceed 75 characters limit because of:
1) long names and long email address
2) some comments on scoped review and acknowledgement, i.e., for a
dedicated pointer on what was reported by the identity in 'Reported-by'
3) some additional comments on CC: stable at vger.org tags

Exclude signature tag lines from this class of warning.

A quick evaluation on v5.6..v5.8 showed that this fix reduces this
warning by a frequency of 17.

A quick manual check found all the dropped warnings related to signature

Signed-off-by: Aditya Srivastava <yashsri421 at gmail.com>
 scripts/checkpatch.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index ac7e5ac80b58..f2369ac29d50 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2961,8 +2961,8 @@ sub process {
 					# file delta changes
 		      $line =~ /^\s*(?:[\w\.\-]+\/)++[\w\.\-]+:/ ||
 					# filename then :
-		      $line =~ /^\s*(?:Fixes:|Link:)/i ||
-					# A Fixes: or Link: line
+		      $line =~ /^\s*(?:Fixes:|Link:|$signature_tags)/i ||
+					# A Fixes: or Link: line or signature tag line
 		      $commit_log_possible_stack_dump)) {
 			     "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);

More information about the Linux-kernel-mentees mailing list