[Linux-kernel-mentees] [PATCH] checkpatch: Fix unescaped left brace

Lukas Bulwahn lukas.bulwahn at gmail.com
Sun Nov 15 20:13:19 UTC 2020


On Sun, Nov 15, 2020 at 6:16 PM Dwaipayan Ray <dwaipayanray1 at gmail.com> wrote:
>
> There is an unescaped left brace in a regex in OPEN_BRACE
> check. This throws a runtime error when checkpatch is run
> with --fix flag and the OPEN_BRACE check is executed.
>
> Fix it by escaping the left brace.
>

Can you find with 'git blame' which commit introduced this issue and
add a Fixes: tag?

Other than that, it looks good.

Lukas

> Signed-off-by: Dwaipayan Ray <dwaipayanray1 at gmail.com>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2749f32dffe9..0da6422cd0fd 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -4505,7 +4505,7 @@ sub process {
>                             $fix) {
>                                 fix_delete_line($fixlinenr, $rawline);
>                                 my $fixed_line = $rawline;
> -                               $fixed_line =~ /(^..*$Type\s*$Ident\(.*\)\s*){(.*)$/;
> +                               $fixed_line =~ /(^..*$Type\s*$Ident\(.*\)\s*)\{(.*)$/;
>                                 my $line1 = $1;
>                                 my $line2 = $2;
>                                 fix_insert_line($fixlinenr, ltrim($line1));
> --
> 2.27.0
>


More information about the Linux-kernel-mentees mailing list