[Linux-kernel-mentees] [PATCH v4] checkpatch: add fix and improve warning msg for Non-standard signature
joe at perches.com
Mon Nov 23 17:33:29 UTC 2020
On Mon, 2020-11-23 at 22:54 +0530, Aditya Srivastava wrote:
> Currently, checkpatch.pl warns for BAD_SIGN_OFF on non-standard signature
I think this proposed change is unnecessary.
> This warning occurs because of incorrect use of signature tags,
> e.g. an evaluation on v4.13..v5.8 showed the use of following incorrect
> signature tags, which may seem correct, but are not standard:
Standards are useful, but standards are not constraints.
> 1) Requested-by (count: 48) => Suggested-by
> Rationale: In an open-source project, there are no 'requests', just
> 'suggestions' to convince a maintainer to accept your patch
There's nothing really wrong with some non-standard signatures.
And I think leaving humor like brown-paper-bag-by: is useful.
Just telling people that they are using a non-standard signature
I think is enough.
More information about the Linux-kernel-mentees