[Linux-kernel-mentees] [PATCH RFC] checkpatch: fix TYPO_SPELLING check for words with apostrophe

Dwaipayan Ray dwaipayanray1 at gmail.com
Thu Nov 26 10:07:15 UTC 2020


On Thu, Nov 26, 2020 at 3:30 PM Lukas Bulwahn <lukas.bulwahn at gmail.com> wrote:
>
> On Thu, Nov 26, 2020 at 10:47 AM Dwaipayan Ray <dwaipayanray1 at gmail.com> wrote:
> >
> > checkpatch reports a false warning for some words containing an
> > apostrophe.
> >
> > A false positive is "doesn't". Occurrence of the word causes
> > checkpatch to emit the following warning:
> >
> > "WARNING: 'doesn'' may be misspelled - perhaps 'doesn't'?"
> >
> > Check if any word character is present after the word boundary
> > in such cases. If present, it means a subpart of the word has
> > been matched and a warning should not be emitted.
> >
> > Reported-by: Peilin Ye <yepeilin.cs at gmail.com>
> > Signed-off-by: Dwaipayan Ray <dwaipayanray1 at gmail.com>
>
> Looks good to me; I am wondering if it is useful to point out to
> rewrite this to "does not" because commit messages are "formal
> content", and not so much spoken language.
>

Yes, that's right. But I guess we could give the authors some freedom
to choose their language style. Personally for me this kind of WARNING
would be annoying. I think a CHECK might be possible, but don't know
if we would be over restricting authors then.

Thanks,
Dwaipayan.


More information about the Linux-kernel-mentees mailing list