[Linux-kernel-mentees] [PATCH] checkpatch: fix TYPO_SPELLING check for words with apostrophe

Dwaipayan Ray dwaipayanray1 at gmail.com
Mon Nov 30 17:03:06 UTC 2020


On Mon, Nov 30, 2020 at 10:13 PM Joe Perches <joe at perches.com> wrote:
>
> On Mon, 2020-11-30 at 20:15 +0530, Dwaipayan Ray wrote:
> > checkpatch reports a false TYPO_SPELLING warning for some words
> > containing an apostrophe.
> >
> > A false positive is "doesn't". Occurrence of the word causes
> > checkpatch to emit the following warning:
> >
> > "WARNING: 'doesn'' may be misspelled - perhaps 'doesn't'?"
> >
> > Check the word boundary for such cases so that words like
> > "doesn't", "zig-zag", etc. aren't misinterpreted due to wrong
> > splitting of the word by the \b regex metacharacter.
> []
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -3106,7 +3106,7 @@ sub process {
> >  # Check for various typo / spelling mistakes
> >               if (defined($misspellings) &&
> >                   ($in_commit_log || $line =~ /^(?:\+|Subject:)/i)) {
> > -                     while ($rawline =~ /(?:^|[^a-z@])($misspellings)(?:\b|$|[^a-z@])/gi) {
> > +                     while ($rawline =~ /(?:^|[^a-z@])($misspellings)(?:\b(?![^\w]?[a-z@]+)|$|[^a-z@])/gi) {
>
> Wouldn't it be simpler to change the existing [^a-z@] blocks to [^a-z@'-] ?
>
Hi,
I tried it and it doesn't seem to work. Probably because the first
group already causes the
word to be captured. In this case `doesn'` was already captured
because of the \b group.

Is the first group modification perhaps okay? Or would you suggest
something else?

Thank you,
Dwaipayan.


More information about the Linux-kernel-mentees mailing list