[Linux-kernel-mentees] [PATCH] checkpatch: add new warnings to author signoff checks.

Lukas Bulwahn lukas.bulwahn at gmail.com
Mon Oct 5 17:01:17 UTC 2020



On Mon, 5 Oct 2020, Lukas Bulwahn wrote:

> 
> 
> On Mon, 5 Oct 2020, Dwaipayan Ray wrote:
> 
> > The author signed-off-by checks are currently very vague.
> > Cases like same name or same address are not handled separately.
> > 
> > For example, running checkpatch on commit be6577af0cef
> > ("parisc: Add atomic64_set_release() define to avoid CPU soft lockups"),
> > gives:
> > 
> > WARNING: Missing Signed-off-by: line by nominal patch author
> > 'John David Anglin <dave.anglin at bell.net>'
> > 
> > The signoff line was:
> > "Signed-off-by: Dave Anglin <dave.anglin at bell.net>"
> > 
> > Clearly the author has signed off but with a slightly different version
> > of his name. A more appropriate warning would have been to point out
> > at the name mismatch instead.
> > 
> > Introduced three new types of warnings:
> > 
> > 1) Address matches, but names are different.
> >    "James Watson <james at gmail.com>", "James <james at gmail.com>"
> > 
> > 2) Name matches, but addresses are different.
> >    "James Watson <james at watson.com>", "James Watson <james at gmail.com>"
> > 
> > 3) Name matches, but addresses without mail extensions are same.
> >    "James Watson <james at gmail.com>", "James Watson <james+a at gmail.com>"
> >
> 
> Make the numbers and cases match the return value and just add which were 
> existent before this patch.
> 
> Looks good to me. Send it out to lkml for discussion.
> 
> I did not check the whitespace and tab issues, but I hope you got it now 
> right.
>

Also, remember to change the subject line of the patch to PATCH v2.

Lukas


More information about the Linux-kernel-mentees mailing list