[Linux-kernel-mentees] [PATCH v4] checkpatch: add new warnings to author signoff checks.

Joe Perches joe at perches.com
Tue Oct 6 20:09:42 UTC 2020


On Wed, 2020-10-07 at 00:31 +0530, Dwaipayan Ray wrote:
> On Wed, Oct 7, 2020 at 12:25 AM Joe Perches <joe at perches.com> wrote:
> > On Wed, 2020-10-07 at 00:21 +0530, Dwaipayan Ray wrote:
> > > The author signed-off-by checks are currently very vague.
> > > Cases like same name or same address are not handled separately.
> > > 
> > > For example, running checkpatch on commit be6577af0cef
> > > ("parisc: Add atomic64_set_release() define to avoid CPU soft lockups"),
> > > gives:
> > 
> > Aren't you still missing emitting an message for cases like
> > 
> > From: "J. Random Developer" <jrd at bigcorp.com>
> > [...]
> > Signed-off-by: "J. Random Developer" (BigCorp) <jrd at bigcorp.com>
> > 
> > Where a comment does not match?
> > 
> > 
> 
> Yes, messages for comments were not emitted previously too
> cause the same_email_address() function just matches name
> and email (discarding name comments and email comments).
> 
> So should I add it to this patch, or should I work on it in a different
> patch perhaps because it involves change on another subroutine?

I suggest adding it to this patch.




More information about the Linux-kernel-mentees mailing list