[Linux-kernel-mentees] [PATCH RFC] checkpatch: add new exceptions to repeated word check
dwaipayanray1 at gmail.com
Mon Oct 12 19:13:33 UTC 2020
> > I did run an evaulation for the single letter case
> > and though it caught one of the lurking 'a's, like in:
> > commit 8d90822643ad ("crypto: engine - support for batch requests")
> > WARNING:REPEATED_WORD: Possible repeated word: 'a'
> > #53: FILE: crypto/crypto_engine.c:472:
> > + * @cbk_do_batch: pointer to a callback function to be invoked when executing a
> > + * a batch of requests.
> > But yikes, it introduced new false positive:
> > commit 6514b25d3fba ("lpfc: Refactor Send LS Request support")
> > WARNING:REPEATED_WORD: Possible repeated word: 'x'
> > #156: FILE: drivers/scsi/lpfc/lpfc_nvme.c:614:
> > + "Data: x%x x%x rc x%x\n",
> > It's probably a bad idea to allow single lettered checking. :-[
> Yeah, I feared that...
> I agree single letter checking is probably not a good idea if we do not
> refine that even more.
> Maybe, we put that aside for now and look at other potential improvements.
Yeah sure, so just quickly sending out the small patch for git modification.
More information about the Linux-kernel-mentees