[Linux-kernel-mentees] [PATCH RFC] checkpatch: extend attributes check to handle more patterns

Joe Perches joe at perches.com
Thu Oct 22 16:14:45 UTC 2020


On Thu, 2020-10-22 at 20:29 +0530, Dwaipayan Ray wrote:
> On Thu, Oct 22, 2020 at 8:22 PM Dwaipayan Ray <dwaipayanray1 at gmail.com> wrote:
> > It is generally preferred that the macros from
> > include/linux/compiler_attributes.h are used, unless there
> > is a reason not to.
[]
> I am a bit worried about the code size though. Is it better altogether
> to have a shared function for parameterized/non parameterized
> __attribute__ arguments? Might have to categorize the macros then.
> 
> What do you think is better?

I think A single shared mechanism better and more extensible.

Renaming all the code types from PREFER_<FOO> to something else
like PREFER_DEFINED_ATTRIBUTE_MACRO would be OK.




More information about the Linux-kernel-mentees mailing list