[Linux-kernel-mentees] [PATCH v3] checkpatch: fix false positives in REPEATED_WORD warning

Aditya yashsri421 at gmail.com
Sat Oct 24 18:12:03 UTC 2020


On 24/10/20 9:03 pm, Joe Perches wrote:
> On Sat, 2020-10-24 at 18:54 +0530, Aditya wrote:
>>> Would you like to work on 
>>> further rules that can be improved with your evaluation approach?
>>
>> Yes, I would like work on further rules.
> 
> Some generic ideas:
> 
> How about working to reduce runtime and complexity by
> making the rules extensible or separable at startup.
> 
> Maybe move each existing rules into a separate
> directory as an individual file and aggregate them at
> checkpatch startup.
> 
> Maybe look at the existing rules that do not have a
> $fix option and add them as appropriate.
> 
> You could fix the multiline indentation where the
> current warning and fix is only for a single line
> 
> 	value = function(arg1,
> 		arg2,
> 		arg3);
> 
> where checkpatch emits only single warning and fix
> for the line with arg2, but not the line with arg3);
> 
> Maybe try to make the coding styles supported more
> flexible:
> 
> Allow braces in different places, support different
> tab indentation sizes, spacing rules around operators,
> function definition layouts, etc.
> 
> 
> 

Thanks for all these suggestions. I'll make observations regarding
these and get back to you :)

Aditya


More information about the Linux-kernel-mentees mailing list