[Linux-kernel-mentees] [PATCH v3 19/28] scsi: hpsa: use generic power management

Don.Brace at microchip.com Don.Brace at microchip.com
Tue Oct 27 16:16:55 UTC 2020

-----Original Message-----
From: Vaibhav Gupta [mailto:vaibhavgupta40 at gmail.com] 
Sent: Thursday, October 1, 2020 7:25 AM
To: Bjorn Helgaas <helgaas at kernel.org>; Bjorn Helgaas <bhelgaas at google.com>; Bjorn Helgaas <bjorn at helgaas.com>; Vaibhav Gupta <vaibhav.varodek at gmail.com>; Adam Radford <aradford at gmail.com>; James E.J. Bottomley <jejb at linux.ibm.com>; Martin K. Petersen <martin.petersen at oracle.com>; Adaptec OEM Raid Solutions <aacraid at microsemi.com>; Hannes Reinecke <hare at suse.com>; Bradley Grove <linuxdrivers at attotech.com>; John Garry <john.garry at huawei.com>; Don Brace <don.brace at microsemi.com>; James Smart <james.smart at broadcom.com>; Dick Kennedy <dick.kennedy at broadcom.com>; Kashyap Desai <kashyap.desai at broadcom.com>; Sumit Saxena <sumit.saxena at broadcom.com>; Shivasharan S <shivasharan.srikanteshwara at broadcom.com>; Sathya Prakash <sathya.prakash at broadcom.com>; Sreekanth Reddy <sreekanth.reddy at broadcom.com>; Suganath Prabu Subramani <suganath-prabu.subramani at broadcom.com>; Jack Wang <jinpu.wang at cloud.ionos.com>
Cc: Vaibhav Gupta <vaibhavgupta40 at gmail.com>; Shuah Khan <skhan at linuxfoundation.org>; linux-kernel at vger.kernel.org; linux-kernel-mentees at lists.linuxfoundation.org; linux-scsi at vger.kernel.org; esc.storagedev at microsemi.com; megaraidlinux.pdl at broadcom.com; MPT-FusionLinux.pdl at broadcom.com
Subject: [PATCH v3 19/28] scsi: hpsa: use generic power management

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Drivers should do only device-specific jobs. But in general, drivers using legacy PCI PM framework for .suspend()/.resume() have to manage many PCI PM-related tasks themselves which can be done by PCI Core itself. This brings extra load on the driver and it directly calls PCI helper functions to handle them.

Switch to the new generic framework by updating function signatures and define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove unnecessary calls to the PCI Helper functions along with the legacy .suspend & .resume bindings.

Signed-off-by: Vaibhav Gupta <vaibhavgupta40 at gmail.com>

Acked-by: Don Brace <don.brace at microchip.com>

 drivers/scsi/hpsa.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 81d0414e2117..70bdd6fe91ee 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -9070,25 +9070,27 @@ static void hpsa_remove_one(struct pci_dev *pdev)
        hpda_free_ctlr_info(h);                         /* init_one 1 */

-static int hpsa_suspend(__attribute__((unused)) struct pci_dev *pdev,
-       __attribute__((unused)) pm_message_t state)
+static int __maybe_unused hpsa_suspend(
+       __attribute__((unused)) struct device *dev)
        return -ENOSYS;

-static int hpsa_resume(__attribute__((unused)) struct pci_dev *pdev)
+static int __maybe_unused hpsa_resume
+       (__attribute__((unused)) struct device *dev)
        return -ENOSYS;

+static SIMPLE_DEV_PM_OPS(hpsa_pm_ops, hpsa_suspend, hpsa_resume);
 static struct pci_driver hpsa_pci_driver = {
        .name = HPSA,
        .probe = hpsa_init_one,
        .remove = hpsa_remove_one,
        .id_table = hpsa_pci_device_id, /* id_table */
        .shutdown = hpsa_shutdown,
-       .suspend = hpsa_suspend,
-       .resume = hpsa_resume,
+       .driver.pm = &hpsa_pm_ops,

 /* Fill in bucket_map[], given nsgs (the max number of

More information about the Linux-kernel-mentees mailing list