[Linux-kernel-mentees] [PATCH RFC] checkpatch: improve handling of email comments

Lukas Bulwahn lukas.bulwahn at gmail.com
Fri Oct 30 05:30:30 UTC 2020


On Thu, Oct 29, 2020 at 8:43 PM Dwaipayan Ray <dwaipayanray1 at gmail.com> wrote:
>
> On Thu, Oct 29, 2020 at 9:17 PM Dwaipayan Ray <dwaipayanray1 at gmail.com> wrote:
> >
> > >
> > > Hi Dwaipayan,
> > > I have generated reports on v5.0..v5.4.
> > >
> > > Relative change in warnings/errors before/after your patch:
> > > https://github.com/AdityaSrivast/kernel-tasks/blob/master/Task4/relative_summary/summary_relative.txt
> > >
> > > Dropped warnings:
> > > https://github.com/AdityaSrivast/kernel-tasks/tree/master/Task4/relative_summary/dropped_warnings
> > >
> > > There may be some discrepancies due to multi-threading. But it should
> > > give us a rough idea.
> > >
> >
> > Thanks Aditya.
> >
> > Seems like 763 false positives were resolved successfully.
> > So I guess the patch is working as intended.
> >
> > My evaluation is currently running and might need a few
> > hours more. I will share it once it completes.
> >
>
> The summary of the analysis is as follows:
>
> Commits checked: 47, 377 from v 5.4
>
> Before the patch:
> BAD_SIGN_OFF: 1516
> FROM_SIGN_OFF_MISMATCH: 931
> NO_AUTHOR_SIGN_OFF: 54
>
> After the patch:
> BAD_SIGN_OFF: 756
> FROM_SIGN_OFF_MISMATCH: 898
> NO_AUTHOR_SIGN_OFF: 54
>
> A total of 793 false positives were resolved.
>
> I think this patch does the job.
> Lukas, what do you think?
>

Agree. The numbers and my quick spot checks suggest it is a good fix
to get merged.

Update the commit message to provide the overall summary of the two
evaluations (by adding them up for the combined git range) and send
the patch to Joe for a quick check.

By the way, I guess it is a good time to share the checkpatch.pl
evaluation scripts with each other, compare them and settle among us
for one common script to use.

(That gives away the mentee intro coding challenge but I am sure we
can come up with a new one...)


Lukas


More information about the Linux-kernel-mentees mailing list