[Linux-kernel-mentees] [PATCH] checkpatch: add fix option for ERROR:GERRIT_CHANGE_ID

[Lukas Bulwahn]

On Fri, 30 Oct 2020, Aditya wrote:

> On 30/10/20 1:53 pm, Aditya Srivastava wrote:
> > Currently, whenever gerrit change id is present in commit, checkpatch.pl
> > gives an error to remove the change id before submitting the patch.
> > 
> > For eg, running checkpatch on commit adc311a5bbf6 ("iwlwifi: bump FW
> > API to 53 for 22000 series"), causes error:
> > 
> > ERROR:GERRIT_CHANGE_ID: Remove Gerrit Change-Id's before submitting
> > upstream
> > Change-Id: I5725e46394f3f53c3069723fd513cc53c7df383d
> > 
> > But there is no --fix option present for this error message, in case
> > user wants to fix it immediately.
> > 
> > To fix this error, delete the corresponding line from the patchfile when
> > checkpatch.pl is executed with --fix
> > 
> > Signed-off-by: Aditya Srivastava <yashsri421 at gmail.com>
> > ---
> >  scripts/checkpatch.pl | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 7800a090e8fe..5329927fc1c1 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -2852,8 +2852,11 @@ sub process {
> >  
> >  # Check for Gerrit Change-Ids not in any patch context
> >  		if ($realfile eq '' && !$has_patch_separator && $line =~ /^\s*change-id:/i) {
> > -			ERROR("GERRIT_CHANGE_ID",
> > -			      "Remove Gerrit Change-Id's before submitting upstream\n" . $herecurr);
> > +			if (ERROR("GERRIT_CHANGE_ID",
> > +			          "Remove Gerrit Change-Id's before submitting upstream\n" . $herecurr) &&
> > +			    $fix) {
> > +                                fix_delete_line($fixlinenr, $rawline);
> > +                        }
> >  		}
> >  
> >  # Check if the commit log is in a possible stack dump
> > 
> 
> Sir I have a doubt: Can I start working on another patch and send that
> too before the first one gets accepted?
>

Sure, you can parallelize your work as much as you can.
Review takes some time: we all have other full-time jobs and many other 
tasks.

When you get feedback, though, I suggest to take that feedback immediately 
and consider reworking your patch.

Lukas