[Linux-kernel-mentees] [PATCH v2] checkpatch: handle line break between commit and hash value

Lukas Bulwahn lukas.bulwahn at gmail.com
Sat Sep 12 14:15:15 UTC 2020



On Sat, 12 Sep 2020, Ayush wrote:

> 
> Before applying this patch, checkpatch.pl reported 342 errors of type
> GIT_COMMIT_ID. After applying patch, errors reduced to 284.
>

I could not reproduce those numbers.

Can you share exactly what you are running? And can you share the list of 
differences in your report?

I have seen that the line number now has also changed in some cases.

We can check if the script really improves the detection or not.

>  my ${CONFIG_} = "CONFIG_";
> -
> +my $c_count = 0;

Why do you think this variable definition is supposed to be placed here?

Where are other variables with similar use defined in the checkpatch.pl 
script?

Lukas


More information about the Linux-kernel-mentees mailing list